Re: [Xen-devel] [PATCH] xen: netback: remove redundant xenvif_put

[Wei Liu <liuw@xxxxxxxxx>]

On Mon, Feb 18, 2013 at 8:29 PM, Andrew Jones <drjones@xxxxxxxxxx> wrote:

netbk_fatal_tx_err() calls xenvif_carrier_off(), which does
a xenvif_put(). As callers of netbk_fatal_tx_err should only
have one reference to the vif at this time, then the xenvif_put
in netbk_fatal_tx_err is one too many.

Hmm... we had a discussion on this not long ago.

http://marc.info/?l=xen-devel&m=136084174026977&w=2

Do you actually experiencing problem?

Wei.

Â

Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx>
---
Âdrivers/net/xen-netback/netback.c | 1 -
Â1 file changed, 1 deletion(-)

diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 2b9520c..c23b9ec 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -893,7 +893,6 @@ static void netbk_fatal_tx_err(struct xenvif *vif)
Â{
    netdev_err(vif->dev, "fatal error; disabling device\n");
    xenvif_carrier_off(vif);
- Â Â Â xenvif_put(vif);
Â}

Âstatic int netbk_count_requests(struct xenvif *vif,
--
1.8.1.2


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel