Re: [Xen-devel] [PATCH 07/13] xen: generalized event channel operations

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, 2013-02-05 at 17:04 +0000, Konrad Rzeszutek Wilk wrote:
> On Thu, Jan 31, 2013 at 02:47:01PM +0000, Wei Liu wrote:
> > Use global pointers in common operations to allow for better code sharing
> > between N-level event channel.
> >
> > Functions which are not suitable for sharing are also taken care of.
> >
> > Also update drivers/xen/evtchn.c to use exported variable instead of macro.
> >
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> >  drivers/xen/events.c |  180 
> > ++++++++++++++++++++++++++++++++------------------
> >  drivers/xen/evtchn.c |   12 ++--
> >  include/xen/events.h |    2 +
> >  3 files changed, 123 insertions(+), 71 deletions(-)
> >
> > diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> > index 0679d27..4820a52 100644
> > --- a/drivers/xen/events.c
> > +++ b/drivers/xen/events.c
> > @@ -51,6 +51,16 @@
> >  #include <xen/interface/hvm/hvm_op.h>
> >  #include <xen/interface/hvm/params.h>
> >
> > +/* N-level event channel, starting from 2 */
> > +unsigned int evtchn_level = 2;
> 
> What if the hypervisor does not support that? Shouldn't be by default
> at 1?
> 

the default implementation is 2 level. ;-)

> > +EXPORT_SYMBOL_GPL(evtchn_level);
> 
> Prefix it please with 'xen'
> 
> > +unsigned int nr_event_channels;
> > +EXPORT_SYMBOL_GPL(nr_event_channels);
> 
> Ditto here.
>  

NP.


Wei.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel