Re: [Xen-devel] [PATCH 10/13] xen: introduce xen_event_channel_register_3level

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, 2013-02-05 at 16:55 +0000, Konrad Rzeszutek Wilk wrote:
> > +
> > +   rc = HYPERVISOR_event_channel_op(EVTCHNOP_register_nlevel, &reg);
> > +   if (rc) {
> > +           free_pages((unsigned long)evtchn_pending, BITMAP_NR_PAGES);
> > +           free_pages((unsigned long)evtchn_mask, BITMAP_NR_PAGES);
> > +           evtchn_pending = NULL;
> > +           evtchn_mask = NULL;
> > +   }
> > +
> > +out:
> > +   kfree(_evtchn_pending);
> > +   kfree(_evtchn_mask);
> > +   kfree(l2sel_mfns);
> > +   kfree(l2sel_offsets);
> 
> So it is OK to just free it even on success??

Yes. They are only used for registration.

And for all the above stuffs regarding comments, I will fix them in
later post.


Wei.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel