Re: [Xen-devel] [PATCH] xen: print "debug=y|n" during hypervisor startup

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Wed, 2013-01-30 at 05:51 -0800, Keir Fraser wrote: 
> > @@ -608,9 +613,9 @@ void __init console_init_preirq(void)
> >      spin_lock(&console_lock);
> >      __putstr(xen_banner());
> >      spin_unlock(&console_lock);
> > -    printk("Xen version %d.%d%s (%s@%s) (%s) %s\n",
> > +    printk("Xen version %d.%d%s (%s@%s debug=%c) (%s) %s\n",
> >             xen_major_version(), xen_minor_version(), xen_extra_version(),
> > -           xen_compile_by(), xen_compile_domain(),
> > +           xen_compile_by(), xen_compile_domain(), debug,
> >             xen_compiler(), xen_compile_date());
> 
> Rather odd to put it in with the xen_compile_by() info. How about before
> xen_compile_date(), and not inside any brackets?
> 
Yeah... I couldn't really make up my mind about where it was better to
put it! :-)

I'll go for what you suggest, thanks.
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel