[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH] Adding support for coverage informations



>>> On 29.01.13 at 12:47, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 29/01/13 11:41, Jan Beulich wrote:
>>>>> On 29.01.13 at 11:56, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
>>> We might have some checks in the tree to ensure that non-init code
>>> cannot reference init code by mistake -- maybe that's what broke the
>>> build for you?
>> No, (sadly) we don't have such checks in place.
> 
> Linux has such checks.  Would it be possible to beg/steal/borrow it in a
> useful fashion?

We could, but code refactoring would then also be needed (since
we do call __init code from non-__init is a few places iirc, suitably
guarded to make sure this really only happens on the boot path).

> With regards to the reentrant NMI issue, I was considering introducing
> __nmi and __mce tags in a similar way to __init.
> 
> At one level, simply having the tags as noops to the compiler would at
> least make programmers consider the implication of what they are
> inserting into the codepaths, but if there is the ability to have
> compiler checks to verify a base level of sanity, that is even better.

Would be nice, yes.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.