Re: [Xen-devel] [PATCH v4 1/2] Xen: Fix live migration while enabling APICV

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.01.13 at 06:56, "Li, Jiongxi" <jiongxi.li@xxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/vmx/intr.c
> +++ b/xen/arch/x86/hvm/vmx/intr.c
> @@ -290,8 +290,8 @@ void vmx_intr_assist(void)
>              vmx_set_eoi_exit_bitmap(v, pt_vector);
>  
>          /* we need update the RVI field */
> -        status &= ~(unsigned long)0x0FF;
> -        status |= (unsigned long)0x0FF & 
> +        status &= ~(unsigned long)VMX_GUEST_INTR_STATUS_SUBFIELD_BITMASK;
> +        status |= (unsigned long)VMX_GUEST_INTR_STATUS_SUBFIELD_BITMASK & 

Why are you keeping these completely bogus casts here?

> +static void vmx_process_isr(int isr, struct vcpu *v)
> +{
> +    unsigned long status;
> +    u8 old;
> +
> +    if ( !cpu_has_vmx_virtual_intr_delivery )
> +        return;
> +
> +    if (isr < 0)

Missing blanks around expression.

> +        isr = 0;
> +
> +    vmx_vmcs_enter(v);
> +    status = __vmread(GUEST_INTR_STATUS);
> +    old = status >> VMX_GUEST_INTR_STATUS_SVI_OFFSET;
> +    if (isr != old) {

Here too. Plus the brace belongs on its own line.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel