Re: [Xen-devel] [PATCH 1/2] Xen: Fix live migration while enabling APICV

["Li, Jiongxi" <jiongxi.li@xxxxxxxxx>]

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxx
> [mailto:xen-devel-bounces@xxxxxxxxxxxxx] On Behalf Of Keir Fraser
> Sent: Saturday, January 26, 2013 3:23 PM
> To: Li, Jiongxi; 'xen-devel@xxxxxxxxxxxxx'
> Subject: Re: [Xen-devel] [PATCH 1/2] Xen: Fix live migration while enabling
> APICV
> 
> On 26/01/2013 06:11, "Li, Jiongxi" <jiongxi.li@xxxxxxxxx> wrote:
> 
> > diff --git a/xen/include/public/arch-x86/hvm/save.h
> > b/xen/include/public/arch-x86/hvm/save.h
> > index a82a5ee..d2a9cf3 100644
> > --- a/xen/include/public/arch-x86/hvm/save.h
> > +++ b/xen/include/public/arch-x86/hvm/save.h
> > @@ -376,6 +376,12 @@ DECLARE_HVM_SAVE_TYPE(IOAPIC, 4, struct
> hvm_hw_vioapic);
> >   * LAPIC
> >   */
> >
> > +struct hvm_hw_lapic_regs {
> > +    uint8_t data[1024];
> > +};
> > +
> > +DECLARE_HVM_SAVE_TYPE(LAPIC_REGS, 5, struct hvm_hw_lapic_regs);
> > +
> >  struct hvm_hw_lapic {
> >      uint64_t             apic_base_msr;
> >      uint32_t             disabled; /* VLAPIC_xx_DISABLED */
> > @@ -383,13 +389,7 @@ struct hvm_hw_lapic {
> >      uint64_t             tdt_msr;
> >  };
> >
> > -DECLARE_HVM_SAVE_TYPE(LAPIC, 5, struct hvm_hw_lapic);
> > -
> > -struct hvm_hw_lapic_regs {
> > -    uint8_t data[1024];
> > -};
> > -
> > -DECLARE_HVM_SAVE_TYPE(LAPIC_REGS, 6, struct hvm_hw_lapic_regs);
> > +DECLARE_HVM_SAVE_TYPE(LAPIC, 6, struct hvm_hw_lapic);
> >
> >
> >  /*
> 
> Why mess with the ordering here? And changing the type numbering is not
> allowed, as that's part of the public interface and makes backward
> compatibility with older save images harder.
Because loading SVI depends on hw_lapic_regs loading and SVI seems to belong to 
the 'hidden' stuff,
I changed the order. But you are right with the compatibility things. I will 
revise the patch to minimize
the change.

Thanks
> 
>  -- Keir
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel