Re: [Xen-devel] [PATCH V1 3/3] Xen processor driver

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Agree, with minor comments below.

Konrad Rzeszutek Wilk wrote:
>> 
>> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
>> index 2dc7022..ca2535a 100644
>> --- a/drivers/xen/Kconfig
>> +++ b/drivers/xen/Kconfig
>> @@ -202,6 +202,18 @@ config XEN_ACPI_HOTPLUG_MEMORY
>>        to hot-add memory at runtime (the hot-added memory cannot be
>>        removed until machine stop), select Y/M here, otherwise select N.
>> 
>> +config XEN_PROCESSOR
> 
> I think the name should be XEN_ACPI_PROCESSOR but then the
> xen-acpi-processor gets in the way.  Hm, perhaps this should be then
> called xen-acpi-cpu-hotplug.c ?
> 
> Would that work?
> 
> Or xen-acpi-cpu.c?
> 
> So then it is called 'XEN_ACPI_CPU' ?

So let's use xen-acpi-cpuhoplut.c and XEN_ACPI_HOTPLUG_CPU,
compared with xen memory hotplug xen-acpi-memhotplug.c and 
XEN_ACPI_HOTPLUG_MEMORY

> 
> 
>> +    tristate "Xen processor driver"
>> +    depends on XEN_STUB && ACPI
> 
> Is there anytime a scenario where the user might compile a kernel
> without DOM0 support, but with Xen_stub && ACPI?

Hmm, let's relax xen-stub.c by 'depends on XEN'
and for xen cpu/mem hotplug add 'depends on XEN_DOM0'

Thanks,
Jinsong
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel