Re: [Xen-devel] [PATCH V1 1/3] Xen stub driver for CPU hotplug

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Konrad Rzeszutek Wilk wrote:
> On Tue, Jan 15, 2013 at 12:30:19PM +0000, Liu, Jinsong wrote:
>>> From 110b4ef3b8ebefeaf68832dd8ef8aa916a782e89 Mon Sep 17 00:00:00
>>> 2001 
>> From: Liu Jinsong <jinsong.liu@xxxxxxxxx>
>> Date: Mon, 14 Jan 2013 15:19:30 +0800
>> Subject: [PATCH 1/3] Xen stub driver for CPU hotplug
>> 
>> Add Xen stub driver for CPU hotplug, early occupy to block native,
>> will be replaced later by real Xen processor driver module.
>> 
>> Signed-off-by: Liu Jinsong <jinsong.liu@xxxxxxxxx>
>> ---
>>  drivers/xen/xen-stub.c |   34 ++++++++++++++++++++++++++++++++--
>>  include/xen/acpi.h     |    6 ++++++
>>  2 files changed, 38 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/xen/xen-stub.c b/drivers/xen/xen-stub.c
>> index 01a49e3..681e9cc 100644
>> --- a/drivers/xen/xen-stub.c
>> +++ b/drivers/xen/xen-stub.c
>> @@ -28,12 +28,13 @@
>>  #include <acpi/acpi_drivers.h>
>>  #include <xen/acpi.h>
>> 
>> +
>> +#ifdef CONFIG_ACPI
>> +
>>  /*--------------------------------------------
>>      stub driver for Xen memory hotplug
>>  --------------------------------------------*/
>> 
>> -#ifdef CONFIG_ACPI
>> -
>>  static const struct acpi_device_id memory_device_ids[] = {
>>      {ACPI_MEMORY_DEVICE_HID, 0},
>>      {"", 0},
>> @@ -57,4 +58,33 @@ static int __init
>>  xen_stub_memory_device_init(void)  }
>> subsys_initcall(xen_stub_memory_device_init); 
>> 
>> +
>> +/*--------------------------------------------
>> +    stub driver for Xen cpu hotplug
>> +--------------------------------------------*/
>> +
>> +static const struct acpi_device_id processor_device_ids[] = {
>> +    {ACPI_PROCESSOR_OBJECT_HID, 0},
>> +    {ACPI_PROCESSOR_DEVICE_HID, 0},
>> +    {"", 0},
>> +};
>> +
>> +struct acpi_driver xen_stub_processor_driver = {
>> +    /* same name as native processor driver to block native loaded */
>> +    .name = "processor", +  .class = ACPI_PROCESSOR_CLASS,
>> +    .ids = processor_device_ids,
>> +};
>> +EXPORT_SYMBOL_GPL(xen_stub_processor_driver);
> 
> Could you make this be
> 
> xen_stub_processor_deinit() instead?
> 

Updated, w/ 2 funcs EXPORT_SYMBOL_GPL to cpu hotplug module:
xen_stub_processor_init()
xen_stub_processor_exit()

Thanks,
Jinsong
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel