Re: [Xen-devel] [RFC PATCH 5/16]: PVH xen: supporting changes.

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Thu, 24 Jan 2013 15:22:21 +0000
Tim Deegan <tim@xxxxxxx> wrote:

> At 17:48 -0800 on 11 Jan (1357926531), Mukesh Rathor wrote:
> > In this patch, we make pv_cpuid() and emulate_forced_invalid_op()
> > public to be used by PVH. Also put vmx functions like vmr(),
> > get_instruction_length(), inlined in header file to be used by PVH.
> > No real code change.
> 
> Please don't export vmr().  It silently suppresses errors, which is OK
> for its current use (as a helper function in the state dump) but not
> for actual guest state manipulations.

Ok, done. I'll assueme it's ok to export get_instruction_length().

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel