Re: [Xen-devel] [PATCH v4 3/4] nested vmx: optimize for bulk access of virtual VMCS

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.01.13 at 15:16, "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> >>> On 22.01.13 at 13:00, Dongxiao Xu <dongxiao.xu@xxxxxxxxx> wrote:
>> > --- a/xen/include/asm-x86/hvm/vcpu.h
>> > +++ b/xen/include/asm-x86/hvm/vcpu.h
>> > @@ -100,6 +100,8 @@ struct nestedvcpu {
>> >       */
>> >      bool_t nv_ioport80;
>> >      bool_t nv_ioportED;
>> > +
>> > +    u64 *vvmcx_buf; /* A temp buffer for data exchange */
>> 
>> VMX-specific field in non-VMX structure? And wouldn't the buffer
>> anyway more efficiently be per-pCPU instead of per-vCPU?
> 
> Yes, it should be VMX specific.
> I also ever thought of putting it per-pCPU, however we need to find somewhere 
> to initialize and finalize the pointer.
> One possible place is in vmx_cpu_up()/vmx_cpu_down(), but I think it is not 
> proper to put the code into the two functions, they are not quite related. 
> Therefore I put it per-vcpu structure.
> Do you have any hint about it?

Calling new functions in vvmx.c from vmx_cpu_up_prepare() and
vmx_cpu_dead() would seem appropriate.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel