Re: [Xen-devel] [PATCH 4/4] docs: check for documentation generation tools in docs/configure.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-01-18 at 16:12 +0000, Roger Pau Monne wrote:
> > @@ -69,6 +75,7 @@ clean:
> >  
> >  .PHONY: distclean
> >  distclean: clean
> > +   rm -rf ../config/Docs.mk config.log config.status autom4te.cache
> 
> By looking at the distclean target from tools, don't you need to remove
> config.cache also?

I thought you might be right but I don't actually see a config.cache
generated anywhere in my tree apart from stubdom/newlib-$(ARCH)/...
after running configure.

This is true in the tree where I commit stuff too (so without these
patches). I also noticed that stubdom/Makefile doesn't clean any of
these things at all.

As an experiment I ran
        $ git clean -f -dx
        $ ./configure 
        $ make distclean 
        $ git clean -f -dx
and the second distclean reported:
        Removing config.log
        Removing config.status
        Removing stubdom/config.log
        Removing stubdom/config.status
        Removing tools/libxl/idl.pyc

So distclean misses a few things but not the one you are worried about.

Regardless I have added config.cache to the rm as you suggested. I have
also appended the following to my series.

Ian.

8<--------------

>From 3f056f79c23a435eb1ab3ab77856a99976d61e06 Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Fri, 18 Jan 2013 16:41:51 +0000
Subject: [PATCH] build: cleanup configure detritus at toplevel and stubdom

These files were left over after
        $ git clean -f -dx
        $ ./configure
        $ make distclean
and picked up by a subsequent.
        $ git clean -f -dx

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 Makefile         |    1 +
 stubdom/Makefile |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index aa3c7bd..2d3ed82 100644
--- a/Makefile
+++ b/Makefile
@@ -167,6 +167,7 @@ endif
        rm -rf dist patches/tmp
        for i in $(ALLKERNELS) ; do $(MAKE) $$i-delete ; done
        rm -rf patches/*/.makedep
+       rm -rf config.log config.status config.cache autom4te.cache
 
 # Linux name for GNU distclean
 .PHONY: mrproper
diff --git a/stubdom/Makefile b/stubdom/Makefile
index 64ee6e2..bd5971e 100644
--- a/stubdom/Makefile
+++ b/stubdom/Makefile
@@ -548,6 +548,8 @@ downloadclean: patchclean
 .PHONY: distclean
 distclean: downloadclean
        -rm ../config/Stubdom.mk
+       rm -rf config.log config.status config.cache \
+               autom4te.cache
 
 ifeq (,$(findstring clean,$(MAKECMDGOALS)))
 $(XEN_ROOT)/config/Stubdom.mk:
-- 
1.7.2.5




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel