[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xsm_remove_from_physmap is (so far) only defined for X86 architecture, not for ARM

On Tue, 2013-01-15 at 14:35 +0000, Daniel De Graaf wrote:
> The rest of the changes look correct. The #ifdefs are a bit ugly, but
> refactoring the MSI code into an arch-specific function should fix
> that. 

I've just sent out a new patch which takes are of only the build failure
on ARM with XSM disabled.

For fixing the flask build on ARM: what does security_device_sid return?
If I want to refactor this:
        #ifdef CONFIG_X86
            if ( desc->msi_desc ) {
                struct pci_dev *dev = desc->msi_desc->dev;
                u32 sbdf = (dev->seg << 16) | (dev->bus << 8) | dev->devfn;
                if (ad) {
                    AVC_AUDIT_DATA_INIT(ad, DEV);
                    ad->device = sbdf;
                return security_device_sid(sbdf, sid);
into an arch specific function I need to be able to return something in
the !desc->msi_desc case. Can a sid be any integer or could I return
e.g. 0 in this case?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.