[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/libxl: Improve videoram setting

Il 10/01/2013 15:40, Stefano Stabellini ha scritto:
On Thu, 10 Jan 2013, Ian Campbell wrote:
On Thu, 2013-01-10 at 14:34 +0000, Stefano Stabellini wrote:
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index e964bf1..2bfbcf4 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -832,7 +832,8 @@ static void parse_config_data(const char *config_source,
      xlu_cfg_get_defbool(config, "localtime", &b_info->localtime, 0);

      if (!xlu_cfg_get_long (config, "videoram", &l, 0))
-        b_info->video_memkb = l * 1024;
+        if ( l > 8 )
+            b_info->video_memkb = l * 1024;
Limiting the minimum amount of videoram could be a good idea, but the
minimum should be 4MB, not 8MB
I'm not convinced by silently limiting the memory, this deserve at least
a WARNING if not an outright failure.

Also, does this sort of limit checking make more sense in libxl?
Yes, you are right on both comments

Nessun virus nel messaggio.
Controllato da AVG - www.avg.com
Versione: 2013.0.2805 / Database dei virus: 2637/6021 -  Data di rilascio: 

About limiting to 8 mb minimum it seems to be necessary on upstream qemu otherwise qemu crash on start, besides libxl already has a default of 8 mb if videoram is not set.
I'll add libxl error if videoram is < 8, can it be good?
About videoram setting, I didn't find the setting for stdvga in the code.
Here for example the commit for cirrus:

Attachment: smime.p7s
Description: Firma crittografica S/MIME

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.