Re: [Xen-devel] [PATCH] tools/libxl: Improve videoram setting

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 10 Jan 2013, Ian Campbell wrote:
> On Thu, 2013-01-10 at 14:34 +0000, Stefano Stabellini wrote:
> > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> > > index e964bf1..2bfbcf4 100644
> > > --- a/tools/libxl/xl_cmdimpl.c
> > > +++ b/tools/libxl/xl_cmdimpl.c
> > > @@ -832,7 +832,8 @@ static void parse_config_data(const char 
> > > *config_source,
> > >      xlu_cfg_get_defbool(config, "localtime", &b_info->localtime, 0);
> > > 
> > >      if (!xlu_cfg_get_long (config, "videoram", &l, 0))
> > > -        b_info->video_memkb = l * 1024;
> > > +        if ( l > 8 )
> > > +            b_info->video_memkb = l * 1024;
> > 
> > Limiting the minimum amount of videoram could be a good idea, but the
> > minimum should be 4MB, not 8MB
> 
> I'm not convinced by silently limiting the memory, this deserve at least
> a WARNING if not an outright failure.
> 
> Also, does this sort of limit checking make more sense in libxl?

Yes, you are right on both comments

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel