Re: [Xen-devel] [PATCH V2] mem_event: Add support for MEM_EVENT_REASON_MSR

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-12-20 at 12:55 +0000, Razvan Cojocaru wrote:
> 
> diff -r b04de677de31 -r e33d3d37dfbf xen/include/public/mem_event.h
> --- a/xen/include/public/mem_event.h    Tue Dec 18 18:16:52 2012 +0000
> +++ b/xen/include/public/mem_event.h    Thu Dec 20 14:52:52 2012 +0200
> @@ -45,6 +45,8 @@
>  #define MEM_EVENT_REASON_CR4         4    /* CR4 was hit: gfn is CR4 value */
>  #define MEM_EVENT_REASON_INT3        5    /* int3 was hit: gla/gfn are RIP */
>  #define MEM_EVENT_REASON_SINGLESTEP  6    /* single step was invoked: 
> gla/gfn are RIP */
> +#define MEM_EVENT_REASON_MSR         7    /* MSR was hit: gfn is MSR value, 
> gla is MSR type;
> +                                             does NOT honour 
> HVMPME_onchangeonly */ 

Why doesn't/shouldn't it support onchangeonly?

HVM_PARAM_MEMORY_EVENT_INT3 and HVM_PARAM_MEMORY_EVENT_SINGLE_STEP seem
not to support it either but they reject attempts to use them with it
(in do_hvm_op). I think this new value should do the same.

By "MSR type" do you mean the address?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel