[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH V3] X86/vMCE: handle broken page with regard to migration
Yes, I will update and send V4 later.
Thanks,
Jinsong
From: dunlapg@xxxxxxxxx [mailto:dunlapg@xxxxxxxxx] On Behalf Of George Dunlap Sent: Wednesday, November 21, 2012 8:17 PM To: Liu, Jinsong Cc: Ian Campbell; Ian Jackson; Jan Beulich; xen-devel@xxxxxxxxxxxxxxxxxxx Subject: Re: [Xen-devel] [PATCH V3] X86/vMCE: handle broken page with regard to migration On Sat, Nov 17, 2012 at 2:04 AM, Liu Jinsong
<jinsong.liu@xxxxxxxxx> wrote:
I think we probably need to include the "last iteration" subcases here as well -- although, probably it would be better to put them in the comments. Also make sure to note that now even suspend may do a second iteration if pages are broken during the suspend operation. Also, what you should do is have the main description always say what the patch does, and then at the bottom have a summary of the changes; for instance: v4: - Adjust variables and patch description based on feedback v3: - Handle pages broken on the last iteration &c
You should remove these until you get another ack (since the patch has changed materially)
I think if you haven't changed the HV part since his ack, you can probably leave this one.
You need more descriptive variables here. Maybe "broken_before_send" and "broken_after_send"? char reportbuf[80]; Maybe, "Pages may have broken between mapping them and sending them. Count the number of broken pages after sending, and if there are more than before sending, do another iteration to make sure the pages are marked broken on the receiving side"? + if ( last_iter ) /* Read the p2m table again */ + for ( j = 0; j < batch; j++ ) /* Count the number of broken pages */ + broken_page_num2 = 0; /* If there are more than before sending, do one more iteration */ + if ( broken_page_num1 < broken_page_num2 ) I think that's all I have. -George _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |