Re: [Xen-devel] [PATCH 5/5] VT-d: adjust IOMMU interrupt affinities when all CPUs are online

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 21/11/2012 11:17, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>> Is this just a handy place to hook?
> 
> Yes.
> 
>> Does it logically make sense?
> 
> No. Just needed to put it somewhere where it would get run at
> the right point in time, and the place here ensures this for both
> boot and resume.

Yuk! And it doesn't work anyway. acpi_dmar_zap() isn't usually called during
boot -- go see it open coded at the end of acpi_parse_dmar(). It's only
called during boot when running tboot.

> Shall I add a comment to this effect?

I would rather have this added as another call to
acpi/power.c:enter_state(). It doesn't logically belong with
acpi_dmar_zap(), nor even with all its callers (e.g.,
tboot_parse_dmar_table).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel