Re: [Xen-devel] [PATCH 5/5] VT-d: adjust IOMMU interrupt affinities when all CPUs are online

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.11.12 at 12:10, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
> On 21/11/2012 10:19, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> 
>> Since these interrupts get setup before APs get brought online, their
>> affinities naturally could only ever point to CPU 0 alone so far.
>> Adjust this to include potentially multiple CPUs in the target mask
>> (when running in one of the cluster modes), and take into account NUMA
>> information (to handle the interrupts on a CPU on the node where the
>> respective IOMMU is).
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> 
>> --- a/xen/drivers/passthrough/vtd/dmar.c
>> +++ b/xen/drivers/passthrough/vtd/dmar.c
>> @@ -839,6 +839,7 @@ void acpi_dmar_reinstate(void)
>>  
>>  void acpi_dmar_zap(void)
>>  {
>> +    adjust_vtd_irq_affinities();
> 
> Is this just a handy place to hook?

Yes.

> Does it logically make sense?

No. Just needed to put it somewhere where it would get run at
the right point in time, and the place here ensures this for both
boot and resume.

Shall I add a comment to this effect?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel