[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH V3] X86/vMCE: handle broken page with regard to migration
From: dunlapg@xxxxxxxxx [mailto:dunlapg@xxxxxxxxx] On Behalf Of George Dunlap Sent: Wednesday, November 21, 2012 1:48 AM To: Liu, Jinsong Cc: Ian Campbell; Ian Jackson; Jan Beulich; xen-devel@xxxxxxxxxxxxxxxxxxx Subject: Re: [Xen-devel] [PATCH V3] X86/vMCE: handle broken page with regard to migration + /* I guess I still don't see the point of this loop. The pages this loop will catch are pages in this scenario: - Page A marked dirty - Last iteration begins; vm paused - Page A sent - Page A marked broken - Last iteration ends [Jinsong]
No, at last lter, there are 4 points:
1. start last iter
2. get and transfer pfn_type to target
3. copy page to target
4. end last iter
this code monitor whether it has a vmce occur at area from point 2 to point 4 (we don't care vmce occur at last iter but before point2)
But in this case, it doesn't really matter that page A is clean on the receiving side; it's already got a clean working copy with the latest data, right? } /* end of this while loop for this iteration */ And what's all this stuff about? Why force a second sweep when we're saving to disk? [Jinsong] if not, saving to disk will do endless loop, since it has no chance to set last_iter=1. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |