[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [xen-unstable test] 14421: regressions - FAIL



On Mon, 2012-11-19 at 19:30 +0000, Andrew Cooper wrote:
> On 19/11/12 19:24, xen.org wrote:
> > flight 14421 xen-unstable real [real]
> > http://www.chiark.greenend.org.uk/~xensrcts/logs/14421/
> >
> > Regressions :-(
> 
> Build failure caused by the first hunk of
> http://xenbits.xen.org/hg/staging/xen-unstable.hg/rev/26facad2f1a1 which
> introduced one open-comment and two close-comments.

So it does, I have pushed the fix below.

I must have somehow overlooked that my usual pre-commit test (which
includes a clean build) didn't actually run to completion. Sorry about
this.

Ian.

>From 602b24f9d77cd269a4f419a49d6e2f88d9f3d68e Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Mon, 19 Nov 2012 19:53:22 +0000
Subject: [PATCH] xen: fix build failure due to extra closing comment

Added by 26173:26facad2f1a1

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 xen/include/public/xen.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h
index bff9542..5593066 100644
--- a/xen/include/public/xen.h
+++ b/xen/include/public/xen.h
@@ -445,7 +445,6 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t);
  * ` @val: The new page table entry, must contain a machine address
  * ` @flags: Control TLB flushes
  */
-*/
 /* These are passed as 'flags' to update_va_mapping. They can be ORed. */
 /* When specifying UVMF_MULTI, also OR in a pointer to a CPU bitmap.   */
 /* UVMF_LOCAL is merely UVMF_MULTI with a NULL bitmap pointer.         */
-- 
1.7.2.5



> 
> 
> >
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> >  build-i386                    4 xen-build                 fail REGR. vs. 
> > 14416
> >  build-i386-oldkern            4 xen-build                 fail REGR. vs. 
> > 14416
> >  build-amd64                   4 xen-build                 fail REGR. vs. 
> > 14416
> >  build-amd64-oldkern           4 xen-build                 fail REGR. vs. 
> > 14416
> >
> > Tests which did not succeed, but are not blocking:
> >  test-amd64-amd64-xl-sedf-pin  1 xen-build-check(1)           blocked  n/a
> >  test-amd64-amd64-xl-pcipt-intel  1 xen-build-check(1)           blocked  
> > n/a
> >  test-amd64-amd64-xl-sedf      1 xen-build-check(1)           blocked  n/a
> >  test-amd64-amd64-pv           1 xen-build-check(1)           blocked  n/a
> >  test-amd64-i386-xl-credit2    1 xen-build-check(1)           blocked  n/a
> >  test-amd64-i386-xl            1 xen-build-check(1)           blocked  n/a
> >  test-amd64-i386-qemuu-rhel6hvm-intel  1 xen-build-check(1)         blocked 
> > n/a
> >  test-amd64-amd64-xl           1 xen-build-check(1)           blocked  n/a
> >  test-amd64-i386-xl-multivcpu  1 xen-build-check(1)           blocked  n/a
> >  test-amd64-i386-rhel6hvm-amd  1 xen-build-check(1)           blocked  n/a
> >  test-amd64-amd64-xl-qemuu-winxpsp3  1 xen-build-check(1)           blocked 
> > n/a
> >  test-amd64-i386-qemuu-rhel6hvm-amd  1 xen-build-check(1)           blocked 
> > n/a
> >  test-amd64-i386-xend-winxpsp3  1 xen-build-check(1)           blocked  n/a
> >  test-amd64-i386-win           1 xen-build-check(1)           blocked  n/a
> >  test-amd64-i386-xl-win-vcpus1  1 xen-build-check(1)           blocked  n/a
> >  test-amd64-i386-pv            1 xen-build-check(1)           blocked  n/a
> >  test-amd64-amd64-xl-win7-amd64  1 xen-build-check(1)           blocked  n/a
> >  test-amd64-i386-win-vcpus1    1 xen-build-check(1)           blocked  n/a
> >  test-amd64-i386-rhel6hvm-intel  1 xen-build-check(1)           blocked  n/a
> >  test-amd64-i386-xl-win7-amd64  1 xen-build-check(1)           blocked  n/a
> >  test-amd64-amd64-xl-winxpsp3  1 xen-build-check(1)           blocked  n/a
> >  test-amd64-i386-pair          1 xen-build-check(1)           blocked  n/a
> >  test-amd64-i386-xl-winxpsp3-vcpus1  1 xen-build-check(1)           blocked 
> > n/a
> >  test-amd64-amd64-pair         1 xen-build-check(1)           blocked  n/a
> >  test-amd64-amd64-xl-win       1 xen-build-check(1)           blocked  n/a
> >  test-amd64-amd64-xl-qemuu-win7-amd64  1 xen-build-check(1)         blocked 
> > n/a
> >  test-amd64-amd64-win          1 xen-build-check(1)           blocked  n/a
> >
> > version targeted for testing:
> >  xen                  fe8034159ac2
> > baseline version:
> >  xen                  321f8487379b
> >
> > ------------------------------------------------------------
> > People who touched revisions under test:
> >   Ian Campbell <ian.campbell@xxxxxxxxxx>
> >   Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >   Jan Beulich <jbeulich@xxxxxxxx>
> >   Keir Fraser <keir@xxxxxxx>
> >   Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> >   Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> >   Wei Wang <wei.wang2@xxxxxxx>
> > ------------------------------------------------------------
> >
> > jobs:
> >  build-amd64                                                  fail
> >  build-i386                                                   fail
> >  build-amd64-oldkern                                          fail
> >  build-i386-oldkern                                           fail
> >  build-amd64-pvops                                            pass
> >  build-i386-pvops                                             pass
> >  test-amd64-amd64-xl                                          blocked
> >  test-amd64-i386-xl                                           blocked
> >  test-amd64-i386-rhel6hvm-amd                                 blocked
> >  test-amd64-i386-qemuu-rhel6hvm-amd                           blocked
> >  test-amd64-amd64-xl-qemuu-win7-amd64                         blocked
> >  test-amd64-amd64-xl-win7-amd64                               blocked
> >  test-amd64-i386-xl-win7-amd64                                blocked
> >  test-amd64-i386-xl-credit2                                   blocked
> >  test-amd64-amd64-xl-pcipt-intel                              blocked
> >  test-amd64-i386-rhel6hvm-intel                               blocked
> >  test-amd64-i386-qemuu-rhel6hvm-intel                         blocked
> >  test-amd64-i386-xl-multivcpu                                 blocked
> >  test-amd64-amd64-pair                                        blocked
> >  test-amd64-i386-pair                                         blocked
> >  test-amd64-amd64-xl-sedf-pin                                 blocked
> >  test-amd64-amd64-pv                                          blocked
> >  test-amd64-i386-pv                                           blocked
> >  test-amd64-amd64-xl-sedf                                     blocked
> >  test-amd64-i386-win-vcpus1                                   blocked
> >  test-amd64-i386-xl-win-vcpus1                                blocked
> >  test-amd64-i386-xl-winxpsp3-vcpus1                           blocked
> >  test-amd64-amd64-win                                         blocked
> >  test-amd64-i386-win                                          blocked
> >  test-amd64-amd64-xl-win                                      blocked
> >  test-amd64-amd64-xl-qemuu-winxpsp3                           blocked
> >  test-amd64-i386-xend-winxpsp3                                blocked
> >  test-amd64-amd64-xl-winxpsp3                                 blocked
> >
> >
> > ------------------------------------------------------------
> > sg-report-flight on woking.cam.xci-test.com
> > logs: /home/xc_osstest/logs
> > images: /home/xc_osstest/images
> >
> > Logs, config files, etc. are available at
> >     http://www.chiark.greenend.org.uk/~xensrcts/logs
> >
> > Test harness code can be found at
> >     http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
> >
> >
> > Not pushing.
> >
> > ------------------------------------------------------------
> > changeset:   26177:fe8034159ac2
> > tag:         tip
> > user:        Ian Campbell <ian.campbell@xxxxxxxxxx>
> > date:        Mon Nov 19 14:25:35 2012 +0000
> >
> >     docs: Include prototype for HYPERVISOR_multicall
> >
> >     Mark-up for inclusion of generated docs.
> >
> >     Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26176:edad24bfa561
> > user:        Ian Campbell <ian.campbell@xxxxxxxxxx>
> > date:        Mon Nov 19 14:25:34 2012 +0000
> >
> >     docs: Document HYPERVISOR_update_descriptor
> >
> >     Mark-up for inclusion of generated docs.
> >
> >     Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26175:b1d36147ac96
> > user:        Ian Campbell <ian.campbell@xxxxxxxxxx>
> > date:        Mon Nov 19 14:25:33 2012 +0000
> >
> >     docs: Add ToC entry for start of day memory layout.
> >
> >     Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26174:dbb8d24bb5ad
> > user:        Ian Campbell <ian.campbell@xxxxxxxxxx>
> > date:        Mon Nov 19 14:25:33 2012 +0000
> >
> >     docs: Document HYPERVISOR_mmuext_op
> >
> >     Mark-up for inclusion of generated docs.
> >
> >     Remove some trailing whitespace.
> >
> >     Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26173:26facad2f1a1
> > user:        Ian Campbell <ian.campbell@xxxxxxxxxx>
> > date:        Mon Nov 19 14:25:32 2012 +0000
> >
> >     docs: document HYPERVISOR_update_va_mapping(_other_domain)
> >
> >     Mark-up for inclusion of generated docs.
> >
> >     Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26172:cfd2772cc717
> > user:        Ian Campbell <ian.campbell@xxxxxxxxxx>
> > date:        Mon Nov 19 14:25:31 2012 +0000
> >
> >     docs: document/mark-up SCHEDOP_*
> >
> >     The biggest subtlety here is there additional argument when op ==
> >     SCHEDOP_shutdown and reason == SHUTDOWN_suspend and its interpretation 
> > by
> >     xc_domain_{save,restore}. Add some clarifying comments to libxc as well.
> >
> >     This patch moves some structs around but there is no functional change
> >     other than improved documentation.
> >
> >     Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26171:31668da0c4d3
> > user:        Jan Beulich <jbeulich@xxxxxxxx>
> > date:        Mon Nov 19 15:15:12 2012 +0100
> >
> >     AMD IOMMU: fix type of "bdf" parameter of 
> > update_intremap_entry_from_msi_msg()
> >
> >     Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >     Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> >
> > changeset:   26170:380ad94f2adc
> > user:        Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> > date:        Mon Nov 19 12:59:51 2012 +0000
> >
> >     Remove tools/vtpm* from MAINTAINERS file
> >
> >     Signed-off-by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> >     Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26169:5a6225e40388
> > user:        Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> > date:        Mon Nov 19 12:59:50 2012 +0000
> >
> >     tools: Remove old vtpm stuff from tools/libxen
> >
> >     Signed-off-by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> >     Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26168:3dc18d679d04
> > user:        Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> > date:        Mon Nov 19 12:59:49 2012 +0000
> >
> >     Remove VTPM_TOOLS from config/Tools.mk.in
> >
> >     Signed-off-by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> >     Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26167:31dcc0e08754
> > user:        Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> > date:        Mon Nov 19 12:59:48 2012 +0000
> >
> >     xend: Remove old vtpm support from xm
> >
> >     Signed-off-by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> >     Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26166:d026f8abca51
> > user:        Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> > date:        Mon Nov 19 12:59:48 2012 +0000
> >
> >     minios: Update mini-os license to support GPL features
> >
> >     This patch updates extras/mini-os/COPYING to explain
> >     which optional features are GPL and what the implications
> >     of enabling them are.
> >
> >     Signed-off-by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> >     Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26165:42a7c393c390
> > user:        Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> > date:        Mon Nov 19 12:59:47 2012 +0000
> >
> >     minios: fix bug in lseek for mini-os
> >
> >     lseek always used files[fd].file.offset. It should
> >     use the offset of whatever union member is actually
> >     being used.
> >
> >     Signed-off-by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> >     Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26164:17539cec2b9d
> > user:        Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > date:        Mon Nov 19 12:59:46 2012 +0000
> >
> >     xen/arm: get the number of cpus from device tree
> >
> >     The system might have fewer cpus than the GIC supports.
> >
> >     Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> >     Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26163:ddb109120dbd
> > user:        Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > date:        Mon Nov 19 12:59:46 2012 +0000
> >
> >     xen/arm: flush D-cache and I-cache when appropriate
> >
> >     - invalidate tlb after setting WXN
> >     - flush D-cache and I-cache after relocation;
> >     - invalidate D-cache after writing to smp_up_cpu;
> >     - flush I-cache after changing HTTBR;
> >     - flush I-cache and branch predictor after writing Xen text ptes.
> >
> >     Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> >     Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > changeset:   26162:9da9781cc3fb
> > user:        Jan Beulich <jbeulich@xxxxxxxx>
> > date:        Mon Nov 19 09:48:22 2012 +0100
> >
> >     vscsiif: minor cleanup
> >
> >     Remove a definition not belonging into the interface, and correct a
> >     few typos in comments.
> >
> >     Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >     Acked-by: Keir Fraser <keir@xxxxxxx>
> >
> >
> > changeset:   26161:9025a10c0561
> > user:        Wei Wang <wei.wang2@xxxxxxx>
> > date:        Mon Nov 19 09:46:46 2012 +0100
> >
> >     AMD IOMMU: Enable HPET broadcast msi remapping
> >
> >     This patch enables hpet msi remapping for amd iommu.
> >
> >     Signed-off-by: Wei Wang <wei.wang2@xxxxxxx>
> >
> >     - use the existing ACPI_IVHD_* #define-s
> >     - warn on finding more than one IVHD HPET entry
> >     - consolidate parameters of update_intremap_entry_from_msi_msg()
> >
> >     Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >     Committed-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> >
> > changeset:   26160:321f8487379b
> > user:        Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > date:        Thu Nov 15 10:25:29 2012 +0000
> >
> >     xen/arm: wake up secondary cpus
> >
> >     Secondary cpus are held by the firmware until we send an IPI to them.
> >
> >     Reordered non-boot cpu wait loop to perform the check before waiting
> >     for an event, to handled the case where the event has already
> >     happened when we reach the loop.
> >
> >     Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> >     Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> >
> > (qemu changes not included)
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxx
> > http://lists.xen.org/xen-devel
> 
> --
> Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
> T: +44 (0)1223 225 900, http://www.citrix.com
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.