Re: [Xen-devel] [PATCH 06/19] xen: use XSM instead of IS_PRIV where duplicated

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.11.12 at 15:59, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote:
> On 11/19/2012 04:08 AM, Jan Beulich wrote:
>>>>> On 16.11.12 at 19:28, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote:
>>> @@ -467,8 +451,8 @@ ret_t do_physdev_op(int cmd, 
>>> XEN_GUEST_HANDLE_PARAM(void) 
> arg)
>>>          if ( copy_from_guest(&irq_op, arg, 1) != 0 )
>>>              break;
>>>  
>>> -        ret = -EPERM;
>>> -        if ( !IS_PRIV(v->domain) )
>>> +        ret = xsm_apic(v->domain, cmd);
>> 
>> Is that the right hook? There's nothing APIC related here.
> 
> There's nothing here at all: the hypercall is a noop. However, when I 
> posted the patch without the XSM check I was told that a check still
> needs to be performed in order to preserve compatability, and the 
> comment below implies that this operation is done prior to programming 
> the ioapic.

But still - this is misleading without at least a code comment.

Jan

>> 
>>> +        if ( ret )
>>>              break;
>>>  
>         /* Vector is only used by hypervisor, and dom0 shouldn't
>            touch it in its world, return irq_op.irq as the vecotr,
>            and make this hypercall dummy, and also defer the vector 
>            allocation when dom0 tries to programe ioapic entry. */
>  




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel