Re: [Xen-devel] [PATCH VTPM v3 03/10] Remove old vtpm support from xm

[Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>]

On 11/19/2012 09:39 AM, Ian Campbell wrote:
> On Mon, 2012-11-19 at 13:50 +0000, Matthew Fioravante wrote:
> > Well I think you could keep the original removal patch and just not
> > apply this one if you don't want to mess with xm and xend.
> The original one was the one which effectively (indirectly) removed the
> xend feature though (unless somehow vtpm still works in xend after
> that?)
It doesn't work in xend after the big removal patch because the files 
xen tries to read will no longer exist. The user can specify vtpm 
devices for xm but the results will be unpredictable. If the user uses 
xm on domains without vtpm everything works like before.
The difference is that the xend and xm code have not been touched. This 
means we have much lower but non-zero chance that xend/xm was somehow 
broken by the removal. The last thing anyone here wants to do is solve 
bug reports on deprecated xend/xm because of a change to the code. That 
being said I'm pretty confident about my vtpm feature removals from xm 
and did some preliminary testing. Still, theres no way to be 100% sure.
> >   The original
> > patch doesn't touch xm or xend and just removes the vtpm and
> > vtpm_manager code. The only reason I'm more inclined to remove all of
> > the old vtpm stuff is because its going to be confusing for users
> > grepping through the tree trying to figure out how to use vtpm.
> Yes, we should either do all or nothing.
>
> Ian.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel