Re: [Xen-devel] [PATCH] Support user domain create extensions

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Juergen Gross writes ("[Xen-devel] [PATCH] Support user domain create 
extensions"):
> This patch supports arbitrary extensions to xl create by being able
> to specify a script which is run at domain creation. The script is
> specified in the xl config file and will be started at domain
> creation with following parameters:
> 
> <script> restore|create <domid> <path of config file>

Thanks.  I think this is a reasonable idea.
I wonder if this might be profitably moved down into libxl.

Also the interface needs work.  At the very least there needs to be a
corresponding "destroy" script invocation.

> To be able to use non-standard devices a new device class "NSTD" is defined.
> The xl framework will remove all NSTD devices when destroying a domain.

Did I miss the implementation of this ?

> +const char *libxl_userdata_path(libxl_ctx *ctx, uint32_t domid,
> +                                const char *userdata_userid,
> +                                const char *wh)

I don't think this is correct.  We shouldn't be exposing the userdata
path like this.  But anyway if we are moving this into libxl then the
config file won't be exposed to the script anyway.

What does your script need the config file for ?  Writing a separate
parser for it is clearly a mistake...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel