[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2] X86/vMCE: handle broken page with regard to migration

>>> On 15.11.12 at 02:52, Liu Jinsong <jinsong.liu@xxxxxxxxx> wrote:
> Generally, there are 2 cases:
> 1. broken page occurs before migration
> 2. broken page occurs during migration
> At the sender
>   For case 1, the broken page would be mapped but not copied to target
>   (otherwise it may trigger more serious error, say, SRAR error).
>   While its pfn_type and pfn number would be transferred to target
>   so that target take appropriate action.
>   For case 2, mce handler marks the broken page to dirty bitmap, so that
>   at copypages stage of migration, its pfn_type and pfn number would be
>   transferred to target and then take appropriate action.
> At the target
>   When migration target would populate pages for guest. As for the case
>   of broken page wrt migration, we prefer keep the corresponding page,
>   for the sake of seamless migration.
>   At target it would set p2m as p2m_ram_broken for broken page. Guest MCE
>   may have good chance to handle its broken page, while if guest access
>   the broken page again it would kill itself as expected.
> Suggested-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> Signed-off-by: Liu Jinsong <jinsong.liu@xxxxxxxxx>
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> Acked-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Acked-by: Jan Beulich <JBeulich@xxxxxxxx>

We're getting closer, but given that this is a re-submission _and_
the subject says v2 (albeit it really is v3 or higher), briefly
mentioning what changed from earlier versions would greatly
help with reviewing.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.