Re: [Xen-devel] [PATCH] MCE: consolidate AMD initialization

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On 10/29/12 10:48, Jan Beulich wrote:
>>>> On 26.10.12 at 10:26, Christoph Egger <Christoph.Egger@xxxxxxx> wrote:
>> On 10/26/12 10:25, Christoph Egger wrote:
>>>
>>> Move AMD specific initialization to AMD files.
>>>
>>> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> 
> Let's do this properly: There's no K7 supporting 64-bit mode afaict,
> so rather than moving around the call to amd_k7_mcheck_init()
> can't we just drop it and the whole (inconsistently named) k7.c file?

I think it is better to apply this first and then remove k7 to
simplify backporting if needed/wanted.

> Also (not in this patch of course), I'd prefer mce_amd_quirks.c
> to get merged into mce_amd.c now that we have the latter.

After some thinking is there some good reason to do this?

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel