[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/3] x86/HPET: cache MSI message last written

  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Fri, 19 Oct 2012 10:32:56 +0100
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Fri, 19 Oct 2012 09:33:24 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: Ac2t3LhLHerXcl9j3k2nz6DzN33JkQ==
  • Thread-topic: [Xen-devel] [PATCH 3/3] x86/HPET: cache MSI message last written

On 19/10/2012 08:57, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>>> That wouldn't be correct: The function _is_ unused (and there's
>>> no issue if it was used afaik), and the __used__ attribute ought
>>> to tell the compiler to keep the function around despite not
>>> having (visible to it) callers.
>> Perhaps our __attribute_used__ definition should change, then?
> I don't think so - this has its own value as is. We may want to add
> a Linux-like __maybe_unused, though.

Could you do that, and add comments to the definitions of __attribute_used__
and __maybe_unused, describing exactly what they are to be used for?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.