[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] libutil.h moved to bsd/libutil.h (Was: Re: [Xen-users] Problem compiling Xen 4.2 from sources)



On Wed, 2012-10-03 at 09:31 +0100, Roger Pau Monne wrote:
> From 250c0d533bab3c9705ade8e4bffed54abcb53b1c Mon Sep 17 00:00:00 2001
> From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> Date: Wed, 3 Oct 2012 10:22:21 +0200
> Subject: [PATCH] autoconf: add -Werror to libutil.h header check
> 
> libutil.h is only needed on BSDs, but not in Linux. Debian package
> libbsd-dev-0.3.0-1 installed a libutil.h overlay that contains a
> #warning, thus making libxl compilation broken due to -Werror.
> 
> Perform the libutil.h check with -Werror, so we don't include this
> bogus header.
> 
> Signed-off-by: Roger Pau Monne <roger.pau@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

and applied.

Arguably, since we compile with -Werror we should run configure with it
too -- but I bet the fallout from doing that would be horrific though!

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.