Re: [Xen-devel] libutil.h moved to bsd/libutil.h (Was: Re: [Xen-users] Problem compiling Xen 4.2 from sources)

[Giorgio Mossa <mossa@xxxxxxxxxxxxxxxxxxxx>]

It seems the patch worked,
thank you very much!!!


On Wed, Oct 03, 2012 at 10:31:57AM +0200, Roger Pau Monné wrote:
> 
> According to the man pages <libutil.h> is only needed on BSDs to be able
> to use openpty et al. Linux should not have this file, could you please
> try the following patch? It should prevent configure (and thus libxl)
> from including the bogus libutil.h header.
> 
> ---
> >From 250c0d533bab3c9705ade8e4bffed54abcb53b1c Mon Sep 17 00:00:00 2001
> From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> Date: Wed, 3 Oct 2012 10:22:21 +0200
> Subject: [PATCH] autoconf: add -Werror to libutil.h header check
> 
> libutil.h is only needed on BSDs, but not in Linux. Debian package
> libbsd-dev-0.3.0-1 installed a libutil.h overlay that contains a
> #warning, thus making libxl compilation broken due to -Werror.
> 
> Perform the libutil.h check with -Werror, so we don't include this
> bogus header.
> 
> Signed-off-by: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> ---
> Please rerun autoconf after applying this patch
> ---
>  tools/m4/ptyfuncs.m4 |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/m4/ptyfuncs.m4 b/tools/m4/ptyfuncs.m4
> index bfea3e1..3e37b5a 100644
> --- a/tools/m4/ptyfuncs.m4
> +++ b/tools/m4/ptyfuncs.m4
> @@ -1,7 +1,14 @@
>  AC_DEFUN([AX_CHECK_PTYFUNCS], [
> +    dnl This is a workaround for a bug in Debian package
> +    dnl libbsd-dev-0.3.0-1. Once we no longer support that
> +    dnl package we can remove the addition of -Werror to
> +    dnl CPPFLAGS.
> +    AX_SAVEVAR_SAVE(CPPFLAGS)
> +    CPPFLAGS="$CPPFLAGS -Werror"
>      AC_CHECK_HEADER([libutil.h],[
>        AC_DEFINE([INCLUDE_LIBUTIL_H],[<libutil.h>],[libutil header file name])
>      ])
> +    AX_SAVEVAR_RESTORE(CPPFLAGS)
>      AC_CACHE_CHECK([for openpty et al], [ax_cv_ptyfuncs_libs], [
>          for ax_cv_ptyfuncs_libs in -lutil "" NOT_FOUND; do
>              if test "x$ax_cv_ptyfuncs_libs" = "xNOT_FOUND"; then
> -- 
> 1.7.7.5 (Apple Git-26)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel