Re: [Xen-devel] [PATCH 4/4] xen: Add V4V implementation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.10.12 at 19:00, Jean Guyader <jean.guyader@xxxxxxxxx> wrote:
> On 4 October 2012 16:12, Tim Deegan <tim@xxxxxxx> wrote:
>> AIUI you need to use compat_handle_okay() instead of guest_handle_okay()
>> to check the handles if is_pv_32on64_domain(current).
>>
> 
> How about something like that?

Could be done, but not by modifying guest_handle_okay() (which
penalizes all its users), nor by (incorrectly) open-coding
compat_handle_okay(). And neither should any such implementation
use is_pv_32on64_domain() twice - use the conditional operator
instead (that way you also avoid evaluating arguments twice).

So you could either introduce e.g. any_guest_handle_okay(), or
switch all current users of guest_handle_okay() to, say,
native_handle_okay() (perhaps with the exception of those where
the compat mode wrapper source files #define guest_handle_okay()
to compat_handle_okay(), which could then be dropped).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel