Re: [Xen-devel] [PATCH xm/xl enhancements for vptm 2/6] add vtpm support to libxl

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-09-18 at 19:11 +0100, Matthew Fioravante wrote:
> This patch adds vtpm support to libxl. It adds vtpm parsing to config
> files and 3 new xl commands:
> vtpm-attach
> vtpm-detach
> vtpm-list

Please can you patch docs/man/xl* as appropriate too.

> Signed off by: Matthew Fioravante matthew.fioravante@xxxxxxxxxx
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -2027,6 +2027,274 @@ int libxl__device_disk_local_detach(libxl__gc
> *gc, libxl_device_disk *disk)
>  }
>  
>  
> /******************************************************************************/
> +int libxl__device_vtpm_setdefault(libxl__gc *gc, libxl_device_vtpm *vtpm)
> +{
> +   if(libxl_uuid_is_nil(&vtpm->uuid)) {
> +      libxl_uuid_generate(&vtpm->uuid);
> +   }
> +   return 0;
> +}
> +
> +static int libxl__device_from_vtpm(libxl__gc *gc, uint32_t domid,
> +                                   libxl_device_vtpm *vtpm,
> +                                   libxl__device *device)
> +{
> +   device->backend_devid   = vtpm->devid;
> +   device->backend_domid   = vtpm->backend_domid;
> +   device->backend_kind    = LIBXL__DEVICE_KIND_VTPM;
> +   device->devid           = vtpm->devid;
> +   device->domid           = domid;
> +   device->kind            = LIBXL__DEVICE_KIND_VTPM;
> +
> +   return 0;
> +}
> +
> +int libxl_device_vtpm_add(libxl_ctx *ctx, uint32_t domid,
> libxl_device_vtpm *vtpm)

It looks like this patch is pretty badly whitespace damaged.

http://wiki.xen.org/wiki/Submitting_Xen_Patches has some hints on using
mercurials patch bomb extension to avoid this sort of thing, and also a
link to Linux's doc on how to configure various popular MUAs to not
corrupt things.

I skimmed the rest of the patch regardless of that and it looks quite
reasonable, thanks.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel