Re: [Xen-devel] [PATCH xm/xl enhancements for vptm 1/6] xl make devid a libxl type

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-09-18 at 19:09 +0100, Matthew Fioravante wrote:
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -16,6 +16,7 @@
>  
>  (** *)
>  type domid = int
> +type devid = int

I don't think libxc exposes the notion of a devid, does it?

In which case there's no need to have a type for it here or in the .mli.
> diff --git a/tools/ocaml/libs/xs/xs.ml b/tools/ocaml/libs/xs/xs.ml
> --- a/tools/ocaml/libs/xs/xs.ml
> +++ b/tools/ocaml/libs/xs/xs.ml
> @@ -17,6 +17,7 @@
>  type perms = Xsraw.perms
>  type con = Xsraw.con
>  type domid = int
> +type devid = int

Likewise xenstore doesn't have a devid either AFAIK.

> diff --git a/tools/python/xen/lowlevel/xl/xl.c
> b/tools/python/xen/lowlevel/xl/xl.c
> --- a/tools/python/xen/lowlevel/xl/xl.c
> +++ b/tools/python/xen/lowlevel/xl/xl.c

Are you basing your patches on xen-unstable? I ask because this file
isn't built there and so I wonder how you noticed it to change it.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel