Re: [Xen-devel] [PATCH] libxl: Fix missing dependency in api check rule

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-09-11 at 16:37 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH] libxl: Fix missing dependency in api check 
> rule"):
> > Although I do wonder if this:
> > 
> > > -_%.api-for-check: %.h
> > > +_%.api-for-check: %.h $(filter-out %.api-ok, $(AUTOINCS))
> > 
> > Indicates that libxl.api-ok doesn't strictly speaking belong in
> > AUTOINCS.
> 
> It would be possible to instead write:
> 
> -$(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS) $(SAVE_HELPER_OBJS): $(AUTOINCS)
> +$(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS) $(SAVE_HELPER_OBJS): $(AUTOINCS) 
> libxl.api-ok
> 
> If you'd prefer that I'd be happy to test that it actually works.

Please do.

Perhaps $(APICHECKS) ? Up to you.

> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel