Re: [Xen-devel] [PATCH] libxl: add missing dependencies of libxl.h

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxl: add missing dependencies 
of libxl.h"):
> On Thu, 2012-09-06 at 18:14 +0100, Olaf Hering wrote:
> > libxl: add missing dependencies of libxl.h

This is not correct.  A dependency in the sense of make is a thing
which is used to construct the target file, not a thing which the
target file's contents refers to.

The correct fix is, I think, this:

diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index a9d9ec6..f48e304 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -119,7 +119,7 @@ libxl.api-ok: check-libxl-api-rules _libxl.api-for-check
        $(PERL) $^
        touch $@
 
-_%.api-for-check: %.h
+_%.api-for-check: %.h $(filter-out %.api-ok, $(AUTOINCS))
        $(CC) $(CPPFLAGS) $(CFLAGS) $(CFLAGS_$*.o) -c -E $< $(APPEND_CFLAGS) \
                -DLIBXL_EXTERNAL_CALLERS_ONLY=LIBXL_EXTERNAL_CALLERS_ONLY \
                >$@.new

Can you confirm that this fixes it for you ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel