Re: [Xen-devel] [PATCH] mem_event: fix regression affecting CR3, CR4 memory events

[Keir Fraser <keir@xxxxxxx>]

On 10/09/2012 22:20, "Steven Maresca" <steve@xxxxxxxxxxxx> wrote:

> Given the refactoring in the commit related to the regression
> http://xenbits.xen.org/hg/xen-unstable.hg/rev/1276926e3795, it seemed
> (to me anyway) that inserting calls as shown in the patch would be
> cleaner, but I can definitely come up with some drawbacks.  However, I
> wanted to get this fixed for 4.2 if at all possible, so I wanted to
> send regardless.
> 
> In terms of drawbacks, this will require some ifdefs for x86_64, for example.
> 
> Any suggestions for the cleanest means of achieving the same in vmx.c?

I don't understand this at all. The original commit moved some CR handling
to common HVM code. Your patch adds some mem_event calls into that common
HVM code. What would need to be "achieved" in vmx.c? What ifdefs would be
required for x86_64?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel