Re: [Xen-devel] [RFC 1/8] move qemu_irq typedef out of cpu-common.h

[Peter Maydell <peter.maydell@xxxxxxxxxx>]

On 29 August 2012 16:36, Igor Mammedov <imammedo@xxxxxxxxxx> wrote:
> Peter Maydell <peter.maydell@xxxxxxxxxx> wrote:
>> I'm not objecting to this patch if it helps us move forwards,
>> but adding the #include to sysemu.h is effectively just adding
>> the definition to another grabbag header (183 files include
>> sysemu.h). It would be nicer long-term to separate out the
>> one thing in this header that cares about qemu_irq (the extern
>> declaration of qemu_system_powerdown).
>> [I'm not really convinced that a qemu_irq is even the right
>> way to signal "hey the system has actually powered down now"...]
>
> Instead of global qemu_system_powerdown we could use notifiers like it's done
> for suspend, I'll post patches today after testing them on target-i386.
>
> BTW getting rid of qemu_system_powerdown is orthogonal to topic of this 
> series.
> I hope you won't object to this patch providing there will be follow on series
> to deal with qemu_system_powerdown.

Yes, as I say, I don't object if this patch is useful in the
meantime.

-- PMM

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel