Re: [Xen-devel] [RFC 1/8] move qemu_irq typedef out of cpu-common.h

[Peter Maydell <peter.maydell@xxxxxxxxxx>]

On 21 August 2012 16:42, Eduardo Habkost <ehabkost@xxxxxxxxxx> wrote:
> diff --git a/qemu-common.h b/qemu-common.h
> index e5c2bcd..6677a30 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -273,7 +273,6 @@ typedef struct PCIEPort PCIEPort;
>  typedef struct PCIESlot PCIESlot;
>  typedef struct MSIMessage MSIMessage;
>  typedef struct SerialState SerialState;
> -typedef struct IRQState *qemu_irq;
>  typedef struct PCMCIACardState PCMCIACardState;
>  typedef struct MouseTransformInfo MouseTransformInfo;
>  typedef struct uWireSlave uWireSlave;
> diff --git a/sysemu.h b/sysemu.h
> index 65552ac..f765821 100644
> --- a/sysemu.h
> +++ b/sysemu.h
> @@ -9,6 +9,7 @@
>  #include "qapi-types.h"
>  #include "notify.h"
>  #include "main-loop.h"
> +#include "hw/irq.h"
>
>  /* vl.c */

I'm not objecting to this patch if it helps us move forwards,
but adding the #include to sysemu.h is effectively just adding
the definition to another grabbag header (183 files include
sysemu.h). It would be nicer long-term to separate out the
one thing in this header that cares about qemu_irq (the extern
declaration of qemu_system_powerdown).
[I'm not really convinced that a qemu_irq is even the right
way to signal "hey the system has actually powered down now"...]

-- PMM

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel