Re: [Xen-devel] [PATCH 1/4] arm: disable distributor delivery on boot CPU only

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-08-06 at 12:55 +0100, Tim Deegan wrote:
> At 11:34 +0000 on 06 Aug (1344252897), Ian Campbell wrote:
> > The secondary processors do not call enter_hyp_mode until the boot CPU
> > has brought most of the system up, including enabling delivery via the
> > distributor. This means that bringing up secondary CPUs unexpectedly
> > disables the GICD again, meaning we get no further interrupts on any
> > CPU.
> > 
> > It's not clear that the distributor actually needs to be disabled to
> > modify the group registers but it seems reasonable that the bringup
> > code should make sure the GICD is disabled even if not doing the
> > transition to hyp mode, so move this to the main flow of head.S and
> > only do it on the boot processor.
> > 
> > For completeness also disable the GICC (CPU interface) on all CPUs
> > too.
> 
> I think that having interrupts disabled is something we can rely on the
> bootloader/firmware handling for us, so this should all stay in
> mode_switch.S for now, and avoid leaking GIC_* magic constants into
> head.S.  (Unless you fancy writing a DT parser in assembler :))

Not really ;-) I'll move this back then.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel