Re: [Xen-devel] [PATCH v2 3/6] xen/arm: implement page reference and grant table functions needed by grant_table.c

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-07-26 at 18:56 +0100, Stefano Stabellini wrote:
> On Tue, 24 Jul 2012, Ian Campbell wrote:
> > On Tue, 2012-07-24 at 11:25 +0100, Stefano Stabellini wrote:
> > > On Mon, 23 Jul 2012, Ian Campbell wrote:
> > > > On Fri, 2012-07-20 at 16:05 +0100, Stefano Stabellini wrote:
> > > > > The implementation is strongly "inspired" by their x86 counterparts,
> > > > > except that we assume paging_mode_external and paging_mode_translate.
> > > > > 
> > > > > TODO: read_only mappings and gnttab_mark_dirty.
> > > > 
> > > > Can we add ASSERT(0) or BUG() or something on those paths, so it becomes
> > > > obvious when we start hitting them.
> > > > 
> > > > ...
> > > > 
> > > > Having read the patch I now see that some of them return errors, but
> > > > others don't and I think they should do something noisy...
> > > 
> > > The only path that is unimplemented is in create_grant_host_mapping, it is
> > > marked with "XXX", and prints an error message and returns an error.
> > 
> > What about gnttab_mark_dirty?
> 
> The problem with gnttab_mark_dirty is that it is called rather often.
> I'll add a static variable so that it is going to print a warning only
> the first time it is called.

That sounds good.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel