[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 3/6] xen/arm: implement page reference and grant table functions needed by grant_table.c

On Fri, 2012-07-20 at 16:05 +0100, Stefano Stabellini wrote:
> The implementation is strongly "inspired" by their x86 counterparts,
> except that we assume paging_mode_external and paging_mode_translate.
> TODO: read_only mappings and gnttab_mark_dirty.

Can we add ASSERT(0) or BUG() or something on those paths, so it becomes
obvious when we start hitting them.


Having read the patch I now see that some of them return errors, but
others don't and I think they should do something noisy...

> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 1832e7f..01a6781 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> +                    rc = -ENOMEM;
> +                    page = alloc_domheap_page(d, 0);
> +                    if ( page == NULL ) {
> +                        printk("p2m_populate_ram: failed to allocate 
> page\n");

Should be a gdprintk or something, since a guest can indirectly trigger
this path.

Otherwise the patch looks good to me but I'd like to see Tim's opinion.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.