Re: [Xen-devel] [PATCH 3/4] arm: implement hypercall continuations

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 25 Jul 2012, Ian Campbell wrote:
> Largely cribbed from x86, register names differ and the return value is r0 ==
> the first argument rather than the hypercall number (which is r12).
> 
> We must only clobber the hypercall arguments if PC has not been changed since
> continuations rely on them.
> 
> Multicall variant is untested, On ARM do_multicall_call is currently a BUG() 
> so
> we obviously don't use that yet. I have left a BUG in the hypercall
> continuation path too since it will need validation once multicalls are
> implemented.
> 
> Since the multicall state is local we do not need a globally atomic
> {test,set}_bit. However we do need to be atomic WRT interrupts so can't just
> use the naive RMW version. Stick with the global atomic implementation for now
> but keep the __ as documentaion of the intention.
> 
> Signed-off-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>

looks good


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel