Re: [Xen-devel] [PATCH v2] libxl: libxl_domain_sched_params_set case for ARINC 653 scheduler

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-07-25 at 16:42 +0100, Andrew Kane wrote:
> Implements sched_arinc653_domain_set to match the existing API. Currently,
> there is no domain-specific configuration when using the ARINC 653 scheduler,
> so we simply return success.
> 
> Signed-off-by: Andrew Kane <Andrew.Kane@xxxxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

There's no need for an equivalent in the get path like Dario suggested?

> 
> ---
> Changed since v1:
>   * changed comment to C-style (/* */)
> 
> diff -r 4a28c496acbf -r c6d90859a30a tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c     Mon Jul 23 17:58:33 2012 +0100
> +++ b/tools/libxl/libxl.c     Wed Jul 25 11:40:25 2012 -0400
> @@ -3642,6 +3642,14 @@ libxl_scheduler libxl_get_scheduler(libx
>      return sched;
>  }
>  
> +static int sched_arinc653_domain_set(libxl__gc *gc, uint32_t domid,
> +                                     const libxl_domain_sched_params *scinfo)
> +{
> +    /* Currently, the ARINC 653 scheduler does not take any domain-specific
> +         configuration, so we simply return success. */
> +    return 0;
> +}
> +
>  static int sched_credit_domain_get(libxl__gc *gc, uint32_t domid,
>                                     libxl_domain_sched_params *scinfo)
>  {
> @@ -3909,6 +3917,9 @@ int libxl_domain_sched_params_set(libxl_
>      case LIBXL_SCHEDULER_CREDIT2:
>          ret=sched_credit2_domain_set(gc, domid, scinfo);
>          break;
> +    case LIBXL_SCHEDULER_ARINC653:
> +        ret=sched_arinc653_domain_set(gc, domid, scinfo);
> +        break;
>      default:
>          LOG(ERROR, "Unknown scheduler");
>          ret=ERROR_INVAL;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel