Re: [Xen-devel] [PATCH v11 09/17] libxl: set nic type of stub to PV instead of copying from the parent

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

Ian Campbell wrote:
> On Tue, 2012-07-24 at 16:27 +0100, Ian Jackson wrote:
>> Roger Pau Monne writes ("[PATCH v11 09/17] libxl: set nic type of stub to PV 
>> instead of copying from the parent"):
> 
>>> +{
>>> +    const libxl_domain_build_info *b_info = &guest_config->b_info;
>>> +    int i;
>>> +
>>> +    if (b_info->type != LIBXL_DOMAIN_TYPE_HVM)
>>> +        return ERROR_INVAL;
>>> +
>>> +    for (i = 0; i < guest_config->num_nics; i++) {
>>> +        libxl_device_nic_init(&nic[i]);
>>> +        memcpy(&nic[i], &guest_config->nics[i], sizeof(nic[i]));
>>> +        nic[i].nictype = LIBXL_NIC_TYPE_VIF;
>>> +        nic[i].backend_domid = 0;
>> As discussed, this should not be hardcoded to 0.
> 
> Nor should the devid which was the next line which you trimmed:
>>> +        nic[i].devid = 0;

I've reworked this on top of IanC patch, I'm only setting nictype to VIF.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel