Re: [Xen-devel] [PATCH] x86/EFI: define and use EFI_DIR make variable, defaulting to /usr/lib64/efi

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-07-23 at 10:07 +0100, Jan Beulich wrote:
> >>> On 23.07.12 at 10:43, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Mon, 2012-07-23 at 09:20 +0100, Jan Beulich wrote:
> >> >>> On 23.07.12 at 10:05, Olaf Hering <olaf@xxxxxxxxx> wrote:
> >> > On Mon, Jul 23, Jan Beulich wrote:
> >> > 
> >> >> >>> On 17.07.12 at 01:50, Matt Wilson <msw@xxxxxxxxxx> wrote:
> >> >> > # HG changeset patch
> >> >> > # User Matt Wilson <msw@xxxxxxxxxx>
> >> >> > # Date 1342481836 0
> >> >> > # Branch efi
> >> >> > # Node ID dd1ab0cae2c870942c2e1b6bc3a507b1a40dae16
> >> >> > # Parent  9950f2dc2ee6dfd172258a5a4ee29809b0ff8263
> >> >> > x86/EFI: define and use EFI_DIR make variable, defaulting to 
> > /usr/lib64/efi
> >> >> > 
> >> >> > After commit 25594:ad08cd8e7097, EFI Xen binaries were installed to
> >> >> > /efi instead of /usr/lib64/efi. This patch restores the previous
> >> >> > behviour established in commit 23645:638f31a30b6c.
> >> >> 
> >> >> I don't follow - what you say suggests that $(LIBDIR) is empty,
> >> >> which certainly isn't the case for me and hence would need
> >> >> explanation of the circumstances under which this happens.
> >> > 
> >> > how is LIBDIR set in your environment?
> >> 
> >> It's not set at all, I'm using what gets defined in config/*.mk.
> > 
> > 25594:ad08cd8e7097 moved LIBDIR to configure and config/Tools.mk so it's
> > not available under xen any more because a) we decided that we didn't
> > want to require configure to be run before building the hypervisor and
> > b) nobody spotted that the EFI stuff under xen/ used LIBDIR (it's not
> > built by make dist? that's what I checked when I tested it).
> 
> It may not get built if your tool chain is too old. Do you see
> xen/xen.efi after the build? If so, I'd also expect it to get
> installed.

I don't get xen.efi. I guess Debian Squeeze's toolstack is too old.

> 
> In any case, moving LIBDIR to the tools' configury process
> may need to be revisisted.

LIB_DIR is a tools related concept. The EFI installation dir is a
semantically different thing even though it happens to also = /usr/lib
or /usr/lib64.

Moving the libdir stuff to configure has clear benefits (i.e. proper
automatic detection of lib vs lib64 on all distros). If anything is to
be revisited then it should be the non-use of configure for the
hypervisor, but I think introducing EFI_DIR is preferable to that
change.

> > What is this stuff installed in /usr/lib*/efi anyway? I suppose it isn't
> > boot time stuff (which should go in /boot or /boot/efi). 
> 
> It *is* boot time stuff, and is does *not* belong into /boot.
> When putting this together, I was told that the EFI partition
> has to be considered volatile (i.e. may get destroyed and
> re-created at any time).

Do you have a reference for this?

OOI what is /boot/efi for if it can be regenerated at any time?

>  This is why elilo.efi also has its real
> home under /usr, not under /boot/efi.

I noticed that (at least on Debian) grub uses /usr/lib/grub/<arch>-efi
and elilo uses /usr/lib/elilo. Does that mean we should be
using /usr/lib/xen/efi rather than /usr/lib/efi?

What is the policy for EFI install location on RPM/LSB based systems?

> > We already have EFI_MOUNTPOINT under xen/*, I think EFI_DIR under there
> > (or in config/*) is fine also.
> 
> That part wasn't controversial (if generally useful), but imo it
> shouldn't expand to an open-coded path (unless put into
> config/x86_64.mk).

I could live with that. Unlike LIBDIR, where getting it wrong can mean
things don't work, getting EFI_DIR wrong is merely ugly.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel