Re: [Xen-devel] [PATCH] x86/EFI: define and use EFI_DIR make variable, defaulting to /usr/lib64/efi

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-07-23 at 09:20 +0100, Jan Beulich wrote:
> >>> On 23.07.12 at 10:05, Olaf Hering <olaf@xxxxxxxxx> wrote:
> > On Mon, Jul 23, Jan Beulich wrote:
> > 
> >> >>> On 17.07.12 at 01:50, Matt Wilson <msw@xxxxxxxxxx> wrote:
> >> > # HG changeset patch
> >> > # User Matt Wilson <msw@xxxxxxxxxx>
> >> > # Date 1342481836 0
> >> > # Branch efi
> >> > # Node ID dd1ab0cae2c870942c2e1b6bc3a507b1a40dae16
> >> > # Parent  9950f2dc2ee6dfd172258a5a4ee29809b0ff8263
> >> > x86/EFI: define and use EFI_DIR make variable, defaulting to 
> >> > /usr/lib64/efi
> >> > 
> >> > After commit 25594:ad08cd8e7097, EFI Xen binaries were installed to
> >> > /efi instead of /usr/lib64/efi. This patch restores the previous
> >> > behviour established in commit 23645:638f31a30b6c.
> >> 
> >> I don't follow - what you say suggests that $(LIBDIR) is empty,
> >> which certainly isn't the case for me and hence would need
> >> explanation of the circumstances under which this happens.
> > 
> > how is LIBDIR set in your environment?
> 
> It's not set at all, I'm using what gets defined in config/*.mk.

25594:ad08cd8e7097 moved LIBDIR to configure and config/Tools.mk so it's
not available under xen any more because a) we decided that we didn't
want to require configure to be run before building the hypervisor and
b) nobody spotted that the EFI stuff under xen/ used LIBDIR (it's not
built by make dist? that's what I checked when I tested it).

What is this stuff installed in /usr/lib*/efi anyway? I suppose it isn't
boot time stuff (which should go in /boot or /boot/efi). 

We already have EFI_MOUNTPOINT under xen/*, I think EFI_DIR under there
(or in config/*) is fine also.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel