Re: [Xen-devel] [PATCH v10 02/19] libxl: change ao_device_remove to ao_device

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v10 02/19] libxl: change ao_device_remove to 
ao_device"):
> Introduce a new structure to track state of device backends, that will
> be used in following patches on this series.
> 
> This structure if used for both device creation and device
> destruction and removes libxl__ao_device_remove.

Thanks.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> +static void device_qemu_timeout(libxl__egc *egc, libxl__ev_time *ev,
> +                                const struct timeval *requested_abs)
> +{
> +    libxl__ao_device *aodev = CONTAINER_OF(ev, *aodev, timeout);
> +    STATE_AO_GC(aodev->ao);
> +    char *be_path = libxl__device_backend_path(gc, aodev->dev);
> +    char *state_path = GCSPRINTF("%s/state", be_path);
> +    int rc = 0;
> +
> +    libxl__ev_time_deregister(gc, &aodev->timeout);

This last call is unnecessary, but harmless.  A timeout is
already deregistered when the event system calls the handler.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel