Re: [Xen-devel] [PATCH v10 12/19] libxl: rename _IOEMU nic type to VIF_IOEMU

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-07-20 at 15:12 +0100, Roger Pau Monne wrote:
> This change will avoid the confusion caused by the fact that IOEMU
> means both PV and TAP network interfaces.

You missed some in comments. e.g. in 

static void libxl__device_nic_from_xs_be(libxl__gc *gc,
                                         const char *be_path,
                                         libxl_device_nic *nic)
...
    /* XXX ioemu nics are not in xenstore at all? */
    nic->nictype = LIBXL_NIC_TYPE_VIF;
    nic->model = NULL; /* XXX Only for TYPE_IOEMU */
    nic->ifname = NULL; /* XXX Only for TYPE_IOEMU */

(I also suspect this comment is just wrong...)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel