Re: [Xen-devel] [PATCH 2/9] tools/build: fix pygrub linking

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("Re: [PATCH 2/9] tools/build: fix pygrub linking"):
> Ian Jackson wrote:
> > Roger Pau Monne writes ("Re: [PATCH 2/9] tools/build: fix pygrub linking"):
> >> Ian Jackson wrote:
> >>> If DESTDIR is not "" then $(PRIVATE_BINDIR)/pygrub is not the same
> >>> directory as $(DESTDIR)/$(BINDIR).
> >> Ok, both conditions have to be meet, that DESTDIR == "" and
> >> PRIVATE_BINDIR == BINDIR (so $(DESTDIR)/$(BINDIR) == $(PRIVATE_BINDIR)).
> > 
> > Right.  OK.  I see now why my test -e is wrong.
> > 
> > But I still think this should be done with an if in the rule's
> > command, rather than a makefile conditional.
> 
> What do you think about:
> 
> set -e; if [ `readlink -f $(DESTDIR)/$(BINDIR)` != \
>              `readlink -f $(PRIVATE_BINDIR)` ]; then \
>                 ln -sf $(PRIVATE_BINDIR)/pygrub $(DESTDIR)/$(BINDIR); \
> fi

That looks plausible.

Can we assume that we are using bash as our shell for these commands ?
If so we can use `test A -ef B'.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel