Re: [Xen-devel] [PATCH] xl: rename "list-vm" command to "vm-list"

[Matt Wilson <msw@xxxxxxxxxx>]

On Thu, Jun 28, 2012 at 08:08:11AM -0700, Ian Jackson wrote:
> Matt Wilson writes ("[Xen-devel] [PATCH] xl: rename "list-vm" command to 
> "vm-list""):
> > diff -r 32034d1914a6 -r 5b1ed71c74d6 docs/man/xl.pod.1
> > --- a/docs/man/xl.pod.1     Thu Jun 07 19:46:57 2012 +0100
> > +++ b/docs/man/xl.pod.1     Thu Jun 28 06:34:26 2012 +0000
> > @@ -617,6 +617,18 @@ different run state is appropriate.  Pin
> >  this, by ensuring certain VCPUs can only run on certain physical
> >  CPUs.
> >  
> > +=item B<vm-list>
> > +
> > +Prints information about all domains except for dom0.
> 
> Doesn't it also exclude dm stubdoms, service domains (stub xenstored),
> etc. ?  IMO it should, and the docs should say so.

The command uses libxl_list_vm(), which does skip stubdoms by checking
libxl_is_stubdom()

> If it doesn't then that's IMO a bug but stubdoms are a bit buggy
> anyway so I don't regard fixing that as a blocker for this patch.  But
> I think we should introduce docs that are correct.
> 
> If you and Ian agree, perhaps you'd like to clarify that (and perhaps
> change the usage message too).

v3, coming up.

Matt

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel