Re: [Xen-devel] Using "xl create" without domain config file

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Jackson writes ("Re: [Xen-devel] Using "xl create" without domain config 
file"):
> W. Michael Petullo writes ("Re: [Xen-devel] Using "xl create" without domain 
> config file"):
> ...
> > -    if (!S_ISREG(stab.st_mode)) {
> > -        LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, "%s is not a plain file", 
> > filename);
> > +    if (S_ISDIR(stab.st_mode)) {
> > +        LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, "%s is a directory", 
> > filename);
> 
> This is not correct.  If, for example, /dev/tty is specified, it will
> go wrong.
> 
> The reason for the restriction to plain files is that those are the
> only thing on which stat works to provide the size.  If we are to
> support other objects, we need to change the reading algorithm.

Another alternative would be to special-case the string "/dev/null"
(in xl, not libxl) and not read a config file at all in that case.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel